Skip to content

[Console] Remove deprecated code #21101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Console] Remove deprecated code #21101

wants to merge 1 commit into from
+4 −0

Conversation

vinceAmstoutz
Copy link
Contributor

Closes #21057

Important:

  • I haven't found anything to delete in the documentation (not documented a priori)
  • OutputInterface is only mentioned (+ review links to the code)

So, in this PR, I only suggest an additional tip to make it easier in the docs to find info on Command::getDefaultName() and Command::getDefaultDescription(), which has been removed in 8.0.

@carsonbot carsonbot added this to the 8.0 milestone Jun 20, 2025
@vinceAmstoutz vinceAmstoutz mentioned this pull request Jun 20, 2025
Merged
@vinceAmstoutz
Copy link
Contributor Author

Lint step will be fixed with #21102

javiereguiluz added a commit that referenced this pull request Jun 20, 2025
@javiereguiluz
minor #21102 Fix lint major symfony version from 7 to 8 (vinceAmstoutz)
a4ea73e 
This PR was merged into the 8.0 branch.

Discussion
----------

Fix lint major symfony version from 7 to 8

Solves failed pipelines for `8.0` branch.

Example: PR #21101 (job https://github.com/symfony/symfony-docs/actions/runs/15779150078/job/44480309482)

Commits
-------

25d3085 docs(core): update symfony major version from 7 to 8
@javiereguiluz
Copy link
Member

Thanks for this contribution!

Note to mergers: I think we should wait to merge #20932 first.

@javiereguiluz
Copy link
Member

Vincent, we merged some Console PRs so this is unlocked for review/merge.

However, while reviewing this again, I noticed that the features removed in #21057 are different. The method removed is getDefaultDescription() insteasd of the setDescription() used in the legacy command definition and that still works.

I searched the docs and couldn't find any occurrence of getDefaultDescription() (or getDefaultName()) in 8.0 branch, so let's close this as "won't merge". If i missed something, please tell me. Thanks!

@vinceAmstoutz
Copy link
Contributor Author

Vincent, we merged some Console PRs so this is unlocked for review/merge.

However, while reviewing this again, I noticed that the features removed in #21057 are different. The method removed is getDefaultDescription() insteasd of the setDescription() used in the legacy command definition and that still works.

I searched the docs and couldn't find any occurrence of getDefaultDescription() (or getDefaultName()) in 8.0 branch, so let's close this as "won't merge". If i missed something, please tell me. Thanks!

Hi Javier, you're right (hence my PR description which mentioned even tail I didn't find anything). I certainly should have commented on the result directly. Thanks and sorry for the lost time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vinceAmstoutz @javiereguiluz @carsonbot